🐛 Letting CAPA bypass updating nodegroup version API call for custom AMI#6044
🐛 Letting CAPA bypass updating nodegroup version API call for custom AMI#6044vishu2498 wants to merge 1 commit into
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @vishu2498. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The PR fixes an issue when user uses a custom AMI with EKS clusters.
When an EKS cluster is made using a certain k8s version using CAPA and any of the nodegroup's k8s version is lesser than that of cluster's k8s version, CAPA's code has the current flow of making an update nodegroup version API call to update the nodegroup's k8s version until it reaches cluster's k8s version.
But in the case where user specifically providers a custom AMI with lesser k8s version that the cluster in the launch template and wants the
AWSManagedMachinePoolto stay on the specified k8s version, CAPA complains with the following error:This PR introduces a fix/change that bypasses CAPA to not make update nodegroup version API call and let the nodes get created & join the cluster gracefully.
It is expected from user to always provide custom AMI for nodegroup which has atmost
n-1k8s version of cluster.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
AI Usage:
The PR contains changes done with the help of Cursor & Claude.
Checklist:
Release note: