Skip to content

🐛 Letting CAPA bypass updating nodegroup version API call for custom AMI#6044

Open
vishu2498 wants to merge 1 commit into
kubernetes-sigs:mainfrom
vishu2498:update-ng-update-call
Open

🐛 Letting CAPA bypass updating nodegroup version API call for custom AMI#6044
vishu2498 wants to merge 1 commit into
kubernetes-sigs:mainfrom
vishu2498:update-ng-update-call

Conversation

@vishu2498

@vishu2498 vishu2498 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
The PR fixes an issue when user uses a custom AMI with EKS clusters.

When an EKS cluster is made using a certain k8s version using CAPA and any of the nodegroup's k8s version is lesser than that of cluster's k8s version, CAPA's code has the current flow of making an update nodegroup version API call to update the nodegroup's k8s version until it reaches cluster's k8s version.

But in the case where user specifically providers a custom AMI with lesser k8s version that the cluster in the launch template and wants the AWSManagedMachinePool to stay on the specified k8s version, CAPA complains with the following error:

Message_: "Launch template details can't be null for Custom ami type node group"  

This PR introduces a fix/change that bypasses CAPA to not make update nodegroup version API call and let the nodes get created & join the cluster gracefully.

It is expected from user to always provide custom AMI for nodegroup which has atmost n-1 k8s version of cluster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

AI Usage:
The PR contains changes done with the help of Cursor & Claude.

Checklist:

  • squashed commits
  • includes documentation
  • includes AI generated content
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:


@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 9, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from faiq and richardcase June 9, 2026 10:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @vishu2498. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants