Modified group assigning on user registeration#19
Open
prahasR wants to merge 2 commits into
Open
Conversation
Owner
|
Hi Prahas,
Sorry to say, but this repository is not well maintained, consider
contributing to IIITB-Hogwarts_Hacktoberfest. Also I saw your PR, and would
suggest you rethink. Think of a situation, when we change the database, or
anything of the sort happens, _id that are statically stored won't remain
the same, and this would be problematic.
…On Sun, Oct 3, 2021 at 11:50 PM Prahas Ranjan ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#19
Commit Summary
- assigning of groups modified
<bd49554>
- modified group assignment to users
<5e1830f>
File Changes
- *M* backend/routes/registration.js
<https://github.com/kartik-pant-23/IIITB-Hogwarts/pull/19/files#diff-ea3c56675cd5db253b961958761b9403f71c5b6d06853f2ab85340201b3cad2e>
(27)
Patch Links:
- https://github.com/kartik-pant-23/IIITB-Hogwarts/pull/19.patch
- https://github.com/kartik-pant-23/IIITB-Hogwarts/pull/19.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APHI3ZJ7RSEYBSWOPXSE7GDUFCNGVANCNFSM5FH33IWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.