Skip to content

fix(train): save model checkpoint before evaluation to prevent losing results on eval crash #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aniruddhaadak80 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(train): save model checkpoint before evaluation to prevent losing results on eval crash #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,9 +609,15 @@ def get_weight_decay(progress):

# Final eval
model.eval()
checkpoint_path = "checkpoint_preeval.pt"
torch.save(model.state_dict(), checkpoint_path)
Comment on lines +612 to +613
with autocast_ctx:
val_bpb = evaluate_bpb(model, tokenizer, DEVICE_BATCH_SIZE)

# Clean up checkpoint if evaluation succeeded
if os.path.exists(checkpoint_path):
os.remove(checkpoint_path)
Comment on lines 614 to +619
Comment on lines +618 to +619

# Final summary
t_end = time.time()
startup_time = t_start_training - t_start
Expand Down