fix(prepare): use true raw bytes for BPB token byte count calculation#607
Open
aniruddhaadak80 wants to merge 1 commit into
Open
fix(prepare): use true raw bytes for BPB token byte count calculation#607aniruddhaadak80 wants to merge 1 commit into
aniruddhaadak80 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates tokenizer preprocessing to compute token byte-lengths using the tokenizer’s decoded raw bytes rather than re-encoding the token string representation.
Changes:
- Compute per-token byte length via
enc.decode_single_token_bytes(token_id)instead oflen(token_str.encode("utf-8")).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| token_bytes_list.append(0) | ||
| else: | ||
| token_bytes_list.append(len(token_str.encode("utf-8"))) | ||
| token_bytes_list.append(len(enc.decode_single_token_bytes(token_id))) |
| token_bytes_list.append(0) | ||
| else: | ||
| token_bytes_list.append(len(token_str.encode("utf-8"))) | ||
| token_bytes_list.append(len(enc.decode_single_token_bytes(token_id))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computes the BPE token byte length using decode_single_token_bytes() instead of len(token_str.encode('utf-8')) to prevent metric inflation from UTF-8 replacement characters on non-UTF-8 tokens (Fixes #384).