feat: add Apple Intel CPU + MPS support#576
Open
amul3 wants to merge 1 commit into
Open
Conversation
Adds backend auto-detection (cuda > mps > cpu) so the training script runs on Apple Intel Macs without a discrete GPU and on Apple Silicon, in addition to the original NVIDIA CUDA path. Key changes: - train.py: lazy/optional Flash-Attention 3 import (CUDA only); SDPA fallback for MPS/CPU; conditional torch.compile (CUDA only); conditional cuda.synchronize / cuda.manual_seed / max_memory_allocated; fp32 embeddings + rotary on non-CUDA backends to avoid slow/unsupported bf16 matmul; per-backend default DEPTH / DEVICE_BATCH_SIZE / TOTAL_BATCH_SIZE / WINDOW_PATTERN so the 5-minute budget actually completes on CPU. - prepare.py: dataloader buffers allocate on detected device; pin_memory only on CUDA; evaluate_bpb pulls device from the model rather than hardcoding cuda. - pyproject.toml: drop hard kernels dep + CUDA-only torch index; move kernels to an optional [cuda] extra; loosen torch to >=2.4 so CPU/MPS wheels resolve. - README: document the new platforms, install matrix, and per-backend defaults. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds backend auto-detection (cuda > mps > cpu) so the training script runs on Apple Intel Macs without a discrete GPU and on Apple Silicon, in addition to the original NVIDIA CUDA path.
Key changes: