fix(hpa): stop flagging HPAs idling at their minimum replica count#1679
Open
AlexsJones wants to merge 1 commit into
Open
fix(hpa): stop flagging HPAs idling at their minimum replica count#1679AlexsJones wants to merge 1 commit into
AlexsJones wants to merge 1 commit into
Conversation
…eplicas The HPA analyzer flagged any ScalingLimited=True condition as a failure, checking only condition.Status and never condition.Reason. An HPA idling at its minimum replica floor reports ScalingLimited=True, reason=TooFewReplicas with desired == current == min, which is normal, healthy behaviour. This produced false-positive Result CRs that fired alerts every reconcile cycle. Skip the failure when reason is TooFewReplicas and the desired replica count equals the configured minimum. Other ScalingLimited reasons, and TooFewReplicas above the floor, are still surfaced. Fixes #1667 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The HPA analyzer (
pkg/analyzer/hpa.go) treated anyScalingLimited=Truecondition as a failure, inspecting onlycondition.Statusand nevercondition.Reason. An HPA idling at its minimum replica floor reportsScalingLimited=True, reason=TooFewReplicaswithdesired == current == min— normal, healthy behaviour. This produced false-positive Result CRs that fired alerts every reconcile cycle.Fix
Skip the
ScalingLimitedfailure whenreason == TooFewReplicasand the desired replica count equals the configured minimum. All otherScalingLimitedreasons, andTooFewReplicasabove the floor, are still surfaced.Tests
TestHPAAnalyzerScalingLimitedTooFewReplicasAtMinIgnored— idle-at-floor HPA produces no results.TestHPAAnalyzerScalingLimitedTooFewReplicasAboveMinFlagged—TooFewReplicasabove the floor is still flagged.ScalingLimitedtests unchanged and passing (they don't setreason/minReplicas, so behaviour is unchanged).Fixes #1667
🤖 Generated with Claude Code