feat: add support of gpt2giga#1635
Conversation
|
7e63788 to
639f4f1
Compare
Signed-off-by: Semyon Inokov <semen.inokov@gmail.com>
|
It would be cleaner to reuse the existing OpenAIClient with a custom base URL instead of adding a new gpt2giga provider, as it avoids duplicated logic and maintenance overhead. If a distinct client is required, consider fixing the variable shadowing, adding tests, and updating docs. |
three-foxes-in-a-trenchcoat
left a comment
There was a problem hiding this comment.
New provider support. The OpenAI-compatible proxy pattern is well-implemented.
Notes:
- Default baseURL is localhost:8090 — consider documenting this as a proxy endpoint that users need to set up themselves.
- No error handling for non-200 response bodies (just returns status code). Consider including the response body in the error for debugging.
- No support for system messages or conversation history (single-turn only). Document this limitation.
LGTM for a new provider.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
==========================================
+ Coverage 34.76% 43.25% +8.48%
==========================================
Files 94 120 +26
Lines 6342 7431 +1089
==========================================
+ Hits 2205 3214 +1009
+ Misses 4046 4005 -41
- Partials 91 212 +121 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @doppoluv — steward check-in here. Alex left design feedback back in April that's still open:
Since then the branch has only picked up merges from
Separately, EasyCLA is still unsigned, which is a hard merge blocker regardless of the approach above — the sign link is in the failing check. Happy to re-review as soon as you've picked a direction and CI is green. If we don't hear back, we'll likely close this as stale in a couple of weeks — just drop a note to keep it open. 🤝 Handled by Alex's Repo Steward — replies reviewed by @AlexsJones. Learn more or run your own: https://github.com/AlexsJones/repo-steward |
📑 Description
Added support for the GPT2Giga proxy provider to integrate with the GigaChat API via OpenAI/Anthropic-compatible interfaces. Key changes include:
✅ Checks
ℹ Additional Information