Skip to content

Add example docker compose environment and related docs#158

Open
alexleach wants to merge 2 commits into
jupyterhub:mainfrom
alexleach:docker-compose
Open

Add example docker compose environment and related docs#158
alexleach wants to merge 2 commits into
jupyterhub:mainfrom
alexleach:docker-compose

Conversation

@alexleach

Copy link
Copy Markdown
Contributor

Hello!

As mentioned in a comment I made yesterday, I thought the documentation and example folder could benefit from some information regarding docker-compose. It's what I use for my jupyterhub environment, and I think works well for single server environments.

Some suggested example configuration and documentation files are attached.

Kind regards,
Alex

@manics

manics commented Feb 22, 2023

Copy link
Copy Markdown
Member

We've got a example docker deployment repo https://github.com/jupyterhub/jupyterhub-deploy-docker so that's another option.

What does everyone else think? Have this example in this repo, or add it to a subdirectory of https://github.com/jupyterhub/jupyterhub-deploy-docker so that repo becomes a set of docker related deployment examples?

@GeorgianaElena

Copy link
Copy Markdown
Member

Hmm, good point!

What does everyone else think? Have this example in this repo, or add it to a subdirectory of https://github.com/jupyterhub/jupyterhub-deploy-docker so that repo becomes a set of docker related deployment examples?

I believe having it in https://github.com/jupyterhub/jupyterhub-deploy-docker makes more sense so my vote goes towards that. I think for trefik-proxy it makes sense to just reference the example from its docs.

@manics

manics commented Feb 22, 2023

Copy link
Copy Markdown
Member

I've opened a PR to move the existing example into a subdirectory, so it'll be easier to add more examples
jupyterhub/jupyterhub-deploy-docker#117

@alexleach

Copy link
Copy Markdown
Contributor Author

Hiya. I was just wondering about this. I'm fine with moving it to the docker-compose example repo, but don't think there's anything I can do until that PR is merged, is there?

Cheers,
Alex

@manics

manics commented Mar 17, 2023

Copy link
Copy Markdown
Member

https://github.com/jupyterhub/jupyterhub-deploy-docker has been refactored to make it easier to add new examples. The README will require some reorganisation, or splitting into separate files (e.g. one README per example?), depending on exactly how the additional examples are documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants