[CILogon] support callable username_claim#823
Open
minrk wants to merge 2 commits into
Open
Conversation
only used when username_claim not specified
consideRatio
approved these changes
Jun 19, 2026
consideRatio
left a comment
Member
There was a problem hiding this comment.
a logging question, but otherwise lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restores compatibility with base class by allowing a callable, both on the class level OAuthenticator.username_claim, and on the per-idp level.
idp-level username_claim has priority, so class-level username_claim is only used when idp.username_derivation.username_claim is not defined.
closes #712 with by allowing callable
username_claimbut if we wanted a simple declarative solution to orcid (e.g. strip url prefix analogous to strip idp domain), we could also do that separately if it's likely to be common enough.Example orcid config: