pre-select saved user options on the spawn form#918
Open
sunu wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
All tests pass locally. Not sure if the failing one is flaky test that needs a retry 🤔 |
Member
|
The CI was fixed in #923 so you can rebase this and try again |
|
@sunu LGTM. Have you tested this yourself? |
Contributor
Author
|
@agoose77 yes, here's a before and after comparison without the changes in this PR and with the changes. Before: Launching a named server doesn't load the previously used profile and image automatically. before.mp4After: Launching a named server does load the previously used profile and image automatically. after.mp4 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preselects user options like profile, image etc if available. This should make sure that the saved options are pre-selected when starting a previously saved named server.
Fixes #917. And would be useful to fix the same downstream issue(2i2c-org/jupyterhub-fancy-profiles#42) in jupyterhub-fancy-profiles