Add proxy tests#180
Conversation
ryanlovett
left a comment
There was a problem hiding this comment.
First, this is amazing, thank you!
I left a couple of questions and comments.
Bonus points if you want to add another test that also launches a user server in a hub. 😄
|
I'll process your other PR before this one, since this one will fail CI due to the problem your other PR fixes. |
|
I've made some changes, including a test for a hub. I split up lab and hub tests mostly for clarity, but they can be merged if you like. I applied your suggestions. The original http code check didn't check For the hub test I threw |
|
@ryanlovett IMHO release v2.5.0 is a broken release due to #178. After this is merged, there should be a new release that includes #179. Thank you. |
|
@benz0li There is a 2.5.1 release on PyPI. There hasn't been a policy to publish on GitHub, and I think we should either always do it or never do it. |
I missed that. Sorry.
👍 |
I used this test to verify changes I made in #179. It's a relatively simple one that uses an R notebook JupyterLab container, installs the latest open source RStudio Server, and verifies the
rstudioendpoint is reachable through the proxy.I've verified that this test fails for
jupyter-rsession-proxy==2.5.0(the affected release) but passes for code on #179 and the previous release.This PR also removes the stale TravisCI status badge, replacing it with the new GHA badge.
Happy to make changes!