Fix resolvePath handling for home-relative paths#1670
Open
MUFFANUJ wants to merge 5 commits into
Open
Conversation
krassowski
reviewed
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes /api/resolvePath for home-relative paths by expanding ~ before resolving server-scope content paths, so ~/… correctly resolves when the expanded filesystem path is inside root_dir, and remains unresolved when outside the contents root.
Changes:
- Expand
~(user home) inFileContentsManager.resolve_pathprior to converting to an API path. - Add a regression test covering
~/…resolution under server scope.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
jupyter_server/services/contents/filemanager.py |
Expands ~ and validates expanded absolute paths against root_dir before resolving to an API path. |
tests/services/kernels/test_api.py |
Adds a regression test ensuring /api/resolvePath resolves home-relative paths within the server root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
krassowski
reviewed
Jul 1, 2026
krassowski
changed the title
resolvePath handling for home-relative paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1669
Expands
~before resolving server contents paths so requests like~/my-preferred-dir/foo.pyresolve correctly when the expanded path is insideroot_dir. Adds a regression test for/api/resolvePathwhile preserving the existing behavior of returning no result for paths outside the contents root.