Introspection fixes#310
Open
esneilm wants to merge 7 commits into
Open
Conversation
Fixed juanifioren#285 -- Ensured standard and custom claims can be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting
…an be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
Revert "Fixed juanifioren#285 -- Ensured standard and custom claims can be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validating audience scope you check for the token to be an authentication token in line 65, but introspection is an OAuth2.0 spec (https://tools.ietf.org/html/rfc7662) meaning that you will have non related user token (when refering to client credentials grant). This validation is great but should be only for user related tokens.
On the other hand one of the purpose of introspection endpoint is to provide what rights of access the token carries adding scope to the members of the response should be included. https://tools.ietf.org/html/rfc7662#section-2.2