ci+docs: fix v0.1.1 main CI + installguard.dev homepage#10
Merged
Conversation
The installguard.dev domain is now registered. Switch the canonical
'homepage' URL in:
* workspace.package.homepage in Cargo.toml (propagates to every
crate's published metadata on crates.io and to 'cargo metadata'
consumers),
* packaging/homebrew/installguard.rb 'homepage' attribute (the
template the release workflow copies into the tap; the next
release-bump PR will carry this through),
* README.md badges, with a new 'web' badge linking to the site.
The repository URL stays on github.com/jt-systems/installguard \u2014
that's the canonical source-tree location and shouldn't move.
Two fixes for the v0.1.1 main-branch CI failures:
1. cargo fmt drift: the multi-line ALLOWLIST in name_similarity.rs
was below rustfmt's array-width threshold and got re-flowed onto
one line. Apply 'cargo fmt --all' so the committed file matches
what 'cargo fmt --check' expects.
2. macos-latest 'cargo build' failed with:
error: unexpected argument 'build' found
Usage: rustup-init[EXE] [OPTIONS]
The CI workflow installed dtolnay/rust-toolchain@stable while
rust-toolchain.toml pins the project to 1.86.0. cargo therefore
asked rustup to switch toolchains \u2014 and on the arm64
macos-latest runner image 'rustup' is shadowed by 'rustup-init',
which doesn't understand the 'build' subcommand. Pin the action
to install '1.86.0' explicitly so no switch is needed.
The release workflow already side-steps this by adding an explicit
'rustup target add' step that triggers a real toolchain install
before cargo runs; leaving release.yml unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two slices that landed on develop after v0.1.1 was tagged:
docs: point homepage at installguard.dev(945a292) — the domain is now live; switchworkspace.package.homepage, the Homebrew formula template, and the README badges.ci: fix fmt drift and pin macOS toolchain to rust-toolchain.toml(60a4255) — the v0.1.1 release-engineering commit landed on main with two latent CI issues that only surface on a real CI run:cargo fmt --checkfailed because rustfmt re-flowed the newALLOWLISTonto a single line.Test (macos-latest)failed witherror: unexpected argument 'build' foundfromrustup-initbecause rust-toolchain.toml pins 1.86.0 but CI installed @stable, and rustup is shadowed by rustup-init on the arm64 macos-latest runner image.Both are fixed; release.yml is unchanged because its explicit
rustup target addstep already side-steps the macOS path.No source changes.