Skip to content

Add Vinyl to devDependencies#33916

Closed
qmonmert wants to merge 1 commit into
jhipster:mainfrom
qmonmert:vinyl
Closed

Add Vinyl to devDependencies#33916
qmonmert wants to merge 1 commit into
jhipster:mainfrom
qmonmert:vinyl

Conversation

@qmonmert

@qmonmert qmonmert commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

vinyl is imported as a type but only resolved transitively; declare it explicitly so it doesn't break when transitive deps change

https://github.com/search?q=repo%3Ajhipster%2Fgenerator-jhipster+vinyl&type=code

@github-actions github-actions Bot added the theme: dependencies Pull requests that update a dependency file label Jun 26, 2026
@qmonmert qmonmert marked this pull request as ready for review June 26, 2026 21:30
@qmonmert qmonmert requested review from DanielFran and mshima June 27, 2026 14:56

@mshima mshima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another type should be used instead

@mshima

mshima commented Jun 27, 2026

Copy link
Copy Markdown
Member

Closing in favor of #33922

@mshima mshima closed this Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme: dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants