Add applicationType/clientFramework/skip{Server,Client} to CoreConfig to remove jhipsterConfig as any#33614
Open
qmonmert wants to merge 1 commit into
Open
Add applicationType/clientFramework/skip{Server,Client} to CoreConfig to remove jhipsterConfig as any#33614qmonmert wants to merge 1 commit into
qmonmert wants to merge 1 commit into
Conversation
… to remove jhipsterConfig as any
Member
|
I don’t think we should move these properties to core. |
mshima
reviewed
May 31, 2026
| entityWithConfig.useMicroserviceJson = entityWithConfig.useMicroserviceJson || entityWithConfig.microserviceName !== undefined; | ||
| entityWithConfig.microserviceAppName = ''; | ||
| if ((generator.jhipsterConfig as any).applicationType === APPLICATION_TYPE_GATEWAY && entityWithConfig.useMicroserviceJson) { | ||
| if (generator.jhipsterConfig.applicationType === APPLICATION_TYPE_GATEWAY && entityWithConfig.useMicroserviceJson) { |
Member
There was a problem hiding this comment.
Generator should be BaseApplicationGenerator. It’s the highest level generator that supports entities.
mshima
reviewed
May 31, 2026
| ignoreErrors, | ||
| prettierPackageJson: true, | ||
| prettierJava: !(this.jhipsterConfig as any).skipServer, | ||
| prettierJava: !this.jhipsterConfig.skipServer, |
Member
There was a problem hiding this comment.
Suggested change
| prettierJava: !this.jhipsterConfig.skipServer, | |
| // Prettier support is implemented in core bootstrap instead of java:bootstrap to improve parallelism in commit. | |
| // Can be replaced by some form of prettier config injection in commit task. | |
| prettierJava: !this.jhipsterConfig.skipServer, |
mshima
reviewed
May 31, 2026
| [ | ||
| { | ||
| when: (this.jhipsterConfig as any).clientFramework === ANGULAR, | ||
| when: this.jhipsterConfig.clientFramework === ANGULAR, |
Member
There was a problem hiding this comment.
Maybe CypressConfig should extend ClientConfig or implement coverage support for others clients.
mshima
reviewed
May 31, 2026
| (this.jhipsterConfig as any).skipClient || | ||
| (buildTool !== 'gradle' && buildTool !== 'maven') | ||
| ) { | ||
| if ((preferredPm && preferredPm !== 'npm') || this.jhipsterConfig.skipClient || (buildTool !== 'gradle' && buildTool !== 'maven')) { |
Member
There was a problem hiding this comment.
skyClient may not be relevant anymore.
If java:node is used, wrapper can be safely used.
Suggested change
| if ((preferredPm && preferredPm !== 'npm') || this.jhipsterConfig.skipClient || (buildTool !== 'gradle' && buildTool !== 'maven')) { | |
| if ((preferredPm && preferredPm !== 'npm') || (buildTool !== 'gradle' && buildTool !== 'maven')) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #30120