Fix AnyBlob content type column removal in incremental changelog#33324
Open
218broadway-svg wants to merge 1 commit into
Open
Fix AnyBlob content type column removal in incremental changelog#33324218broadway-svg wants to merge 1 commit into
218broadway-svg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17613.
Summary
<field>_content_typeLiquibase column when anAnyBlob/blob field is removed in an incremental changelogAnyBlobfieldVerification
npm installnpm run check-typesnpx prettier --check generators/liquibase/incremental-liquibase.spec.tsI also tried to run the focused test with:
npx esmocha generators/liquibase/incremental-liquibase.spec.ts --forbid-only --grep 'blob field with content type'On Windows this currently fails before the assertion with Node's ESM loader rejecting an absolute
c:path (ERR_UNSUPPORTED_ESM_URL_SCHEME). The added regression test is scoped to the generated changelog output and should run normally in the Linux CI environment.