Skip to content

[Angular] Replace Observable<undefined> with Observable<{}>#32617

Closed
qmonmert wants to merge 1 commit into
jhipster:mainfrom
qmonmert:angvoid
Closed

[Angular] Replace Observable<undefined> with Observable<{}>#32617
qmonmert wants to merge 1 commit into
jhipster:mainfrom
qmonmert:angvoid

Conversation

@qmonmert

@qmonmert qmonmert commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@qmonmert qmonmert force-pushed the angvoid branch 2 times, most recently from 0c32f7a to bc4c8be Compare March 8, 2026 20:19
@qmonmert qmonmert changed the title [Angular] Replace Observable<undefined> with Observable<void> [Angular] Replace Observable<undefined> with Observable<{}> Mar 8, 2026
@qmonmert qmonmert marked this pull request as ready for review March 8, 2026 20:47
@qmonmert

qmonmert commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

@mshima WDYT about this update?

@mshima

mshima commented Mar 8, 2026

Copy link
Copy Markdown
Member

Delete api return no content:

return ResponseEntity.noContent().headers(HeaderUtil.createEntityDeletionAlert(applicationName, <%= enableTranslation %>, ENTITY_NAME, id<% if (!primaryKey.fields[0].fieldTypeString) { %>.toString()<% } %>)).build();

 {} (Empty Object Type)
{} represents any value except for null and undefined. It is a valid object but has no explicitly defined properties or methods.

So undefined seems for appropriate to the no-content response.

@qmonmert

qmonmert commented Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

ok

@qmonmert qmonmert closed this Mar 8, 2026
@mraible mraible added this to the 9.0.0 milestone Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants