Skip to content

[Angular] Sonar: Add at least one assertion to this test case #32603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshima merged 1 commit into from
Mar 7, 2026
Merged

[Angular] Sonar: Add at least one assertion to this test case #32603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions generators/angular/__snapshots__/generator.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,12 +1240,10 @@ describe("UserManagement Service", () => {
});

it("should delete a UserManagement", () => {
const expected = true;

service.delete("ABC").subscribe();

const req = httpMock.expectOne({ method: "DELETE" });
req.flush({ status: 200 });
const requests = httpMock.match({ method: "DELETE" });
expect(requests.length).toBe(1);
});

describe("addUserManagementToCollectionIfMissing", () => {
Expand Down
6 changes: 2 additions & 4 deletions ...ates/src/main/webapp/app/entities/_entityFolder_/service/_entityFile_.service.spec.ts.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,10 @@ describe('<%= entityAngularName %> Service', () => {

<%_ if (!readOnly) { _%>
it('should delete a <%= entityAngularName %>', () => {
const expected = true;

service.delete(<%- tsKeyId %>).subscribe();

const req = httpMock.expectOne({ method: 'DELETE' });
req.flush({ status: 200 });
const requests = httpMock.match({ method: 'DELETE' });
expect(requests.length).toBe(1);
});
<%_ } _%>

Expand Down
Loading