spring-boot: move oauth2 configuration to secret-samples#32550
Merged
Conversation
OIDC configuration should be customized by each application depending on its environment. To encourage this, the configuration should be moved to secret-samples, forcing users to explicitly customize it for the prod profile.
DanielFran
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OIDC configuration should be customized by each application depending on its environment. To encourage this, the configuration should be moved to
secret-samples, forcing users to explicitly customize it for theprodprofile.The
devprofile enablessecret-samplesby default, and we also enable it in the scripts. Otherwise, the default configuration would be applied.The suggested fix in #30206 is to remove the
offline_accessscope.The
offline_accessscope was added a few years ago and, as far as I know, it is mainly used by the Ionic blueprint.The initially proposed fix resulted in several PRs:
However, these PRs mainly introduce alternative configurations that are expected to be customized in production environments anyway.
Fixes #30206.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.