Skip to content

Added a div container wrapping promotion details in order to ease styling#59

Open
mtauzin wants to merge 2 commits into
jenkinsci:masterfrom
mtauzin:master
Open

Added a div container wrapping promotion details in order to ease styling#59
mtauzin wants to merge 2 commits into
jenkinsci:masterfrom
mtauzin:master

Conversation

@mtauzin

@mtauzin mtauzin commented Jun 15, 2015

Copy link
Copy Markdown

No description provided.

mtauzin added 2 commits June 10, 2015 17:23
Added a div container wrapping promotion details in order to ease styling
@jenkinsadmin

Copy link
Copy Markdown
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong number of tabs

@oleg-nenashev

Copy link
Copy Markdown
Member

Such approach may impact other UI patches, but probably it's the only way

@oleg-nenashev

Copy link
Copy Markdown
Member

@mtauzin
Do you consider any CSS styling for this class? If yes, it could be done in the plugin directly (if it is generic enough)

@mtauzin mtauzin closed this Aug 25, 2015
@mtauzin

mtauzin commented Aug 25, 2015

Copy link
Copy Markdown
Author

@oleg-nenashev
Yes I do, the current style i'm applying throught css is :
padding-left: 40px; border-left:2px solid black;
css

@mtauzin mtauzin reopened this Aug 25, 2015
@oleg-nenashev

Copy link
Copy Markdown
Member

It would make sense as a default behavior (sorry for a necro-post, have missed the response)

@oleg-nenashev

Copy link
Copy Markdown
Member

Can be merged. There is just a mess with tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants