[JENKINS-57816] Self-Promotion Condition feature with Pipeline Compatibility#136
Open
dernDren161 wants to merge 1 commit into
Open
[JENKINS-57816] Self-Promotion Condition feature with Pipeline Compatibility#136dernDren161 wants to merge 1 commit into
dernDren161 wants to merge 1 commit into
Conversation
oleg-nenashev
requested changes
Jun 19, 2019
oleg-nenashev
left a comment
oleg-nenashev
left a comment
Member
There was a problem hiding this comment.
I am not sure what is it. In https://issues.jenkins-ci.org/browse/JENKINS-57637 and the discussions over past weeks we agreed that you refactor the extension points, But here you create new ones instead of doing that.
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public abstract class PipelinePromotionCondition implements ExtensionPoint, Describable<PipelinePromotionCondition> { |
Member
There was a problem hiding this comment.
There is no need in separate extension point. The existing ones should be refactored as we agreed before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To show the compatibility of Self promotion with the pipelines.
Please go through this documentation to know more about the PR and my relevant questions.
See JENKINS-57816.
Your checklist for this pull request
Restricted(docs)CC
@oleg-nenashev @MadsNielsen @jonbrohauge @bicschneider