Skip to content

195 scopes for dockerlogin action #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hupling wants to merge 6 commits into
base: main
Choose a base branch
from
Open

195 scopes for dockerlogin action #214

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d230fe
Add scope parameter for Docker registry login
hupling Mar 20, 2026
dcf3f10
Update Docker image scope in action.yml
hupling Mar 20, 2026
f73b7ff
Simplify Docker image scope in action.yml
hupling Mar 20, 2026
9bcce00
Update action.yml
hupling Mar 20, 2026
e76939d
Update action.yml
hupling Mar 20, 2026
5db7f18
Update action.yml
hupling Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion action-templates/actions/action-build-image/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ runs:
registry: ${{ inputs.registry }}
username: ${{ inputs.registry-username }}
password: ${{ inputs.registry-password }}
scope: "@push"
- name: Extract metadata (tags, labels) for Docker
id: meta
uses: docker/metadata-action@c299e40c65443455700f0fdfc63efafe5b349051 # v5.10.0
Expand All @@ -64,4 +65,4 @@ runs:
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
github-token: ${{ github.token }}
# github-token: ${{ github.token }}

@coderabbitai coderabbitai Bot Mar 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Remove or document the commented-out code.

Commented code without explanation creates maintenance confusion. Since authentication is already handled by the docker/login-action step, the github-token input is likely unnecessary here.

If intentionally removed: delete the line entirely.
If kept for reference: add a comment explaining why it's disabled and under what circumstances it might be re-enabled.

🧹 Suggested fix: remove the commented line 
        tags: ${{ steps.meta.outputs.tags }}
        labels: ${{ steps.meta.outputs.labels }}
-        # github-token: ${{ github.token }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# github-token: ${{ github.token }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@action-templates/actions/action-build-image/action.yml` at line 68, The
commented-out input "github-token: ${{ github.token }}" in action.yml should be
either removed or documented: if it's unused because authentication is performed
by the docker/login-action step, delete that commented line; otherwise replace
the comment with a short explanatory comment above or inline the line stating
why it's disabled and when to re-enable (e.g., "disabled because
docker/login-action handles auth; enable if using action's built-in docker
auth"), referencing the exact commented token string so reviewers can find and
update the "github-token" entry in action.yml.

Loading