3131 Suche nach ungültigen Wahlscheinen muss auch nicht Ziffernzeichen erlauben

[ThoGro]

Beschreibung:

Eingabefeld zur Wahlscheinnummer als VTextarea

Weitere Regeln für das neue Inputfeld können nach der Migrationsbereitswahl, wie im Issue nachträglich beschrieben, ergänzt werden. Neues Issue hierfür #3159

Definition of Done (DoD):

Frontend

• Naming Conventions beachtet
• Doku aktualisiert
  • Fachliche Beschreibung
  • UI/UX-Adrs
• Unit-Tests gepflegt
• Texte auf Rechtschreibung und Grammatik geprüft
• Texte auf gendergerechte Sprache geprüft

Referenzen¹:

Closes #3131

Summary by CodeRabbit

• Bug Fixes

  • Updated the invalid ballot certificate number field to accept text input, improving compatibility with entered values.
  • Preserved required-field validation and save/reset behavior.

• Tests

  • Updated coverage for the new text-based input and string values.
  • Retained checks for saving, returning, and disabled states.

Footnotes

1. Nicht zutreffende Referenzen vor dem Speichern entfernen ↩

[coderabbitai]

📝 Walkthrough

Walkthrough

The invalid ballot number field was changed from a numeric input to a textarea. Its state, validation rule, and change handler now accept strings. Tests were updated to use VTextarea, the new data-test selector, and string input values. Numeric minimum and maximum boundary tests were removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes switch the wahlscheinnummer input to text and update tests, satisfying the requirement to accept arbitrary text characters.
Out of Scope Changes check	✅ Passed	The diff stays focused on the input type and corresponding tests, with no clear unrelated changes introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title matches the main change by stating that invalid ballot search should accept non-digit characters.
Description check	✅ Passed	The description follows the template with a clear summary, Frontend DoD items, and references.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 3131-suche-nach-ungültigen-wahlscheinen-muss-auch-nicht-ziffernzeichen-erlauben

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

wls-gui-wahllokalsystem/tests/components/wahlhandlung/TheUngueltigeWahlscheineVerifyCard.spec.ts (1)

243-244: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add coverage for an alphanumeric ballot number.

The changed flow still enters only "123", so it would pass even if numeric-only input were accidentally restored. Add a test using a known fixture such as W-11-162-00-1234567 and verify the search/reset behavior with that value.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@wls-gui-wahllokalsystem/tests/components/wahlhandlung/TheUngueltigeWahlscheineVerifyCard.spec.ts`
around lines 243 - 244, Add coverage in TheUngueltigeWahlscheineVerifyCard test
around wahlscheinnummerInput using the alphanumeric fixture W-11-162-00-1234567
instead of only the numeric value. Verify that the search and reset behavior
succeeds with this value, preserving the existing test flow.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@wls-gui-wahllokalsystem/tests/components/wahlhandlung/TheUngueltigeWahlscheineVerifyCard.spec.ts`:
- Around line 243-244: Add coverage in TheUngueltigeWahlscheineVerifyCard test
around wahlscheinnummerInput using the alphanumeric fixture W-11-162-00-1234567
instead of only the numeric value. Verify that the search and reset behavior
succeeds with this value, preserving the existing test flow.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1064153-ed09-416d-a418-822146bdd6ff

📥 Commits

Reviewing files that changed from the base of the PR and between 5eb2ee4 and 203964b.

⛔ Files ignored due to path filters (8)

• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderEmptyCard_when_mounted.html is excluded by !**/visual logic/**.html
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderInvalidWahlscheinWithDisabledSaveButtonAndChangeSearchButtonLabel_when_wahlscheinnummerIsPartOfUngueltigeWahlscheine.html is excluded by !**/visual logic/**.html
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderInvalidWahlscheinWithEnabledSaveButtonAndChangeSearchButtonLabel_when_wahlscheinnummerIsPartOfUngueltigeWahlscheineAndAbstimmungEingetragen.html is excluded by !**/visual logic/**.html
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderRefreshButtonInLoadingState_when_ungueltigeWahlscheineLoadingIsTrue.html is excluded by !**/visual logic/**.html
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderValidWahlscheinAndChangeSearchButtonLabel_when_wahlscheinnummerIsNotPartOfUngueltigeWahlscheine.html is excluded by !**/visual logic/**.html
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderWarning_when_noDataIsAvailable.html is excluded by !**/visual logic/**.html
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderWarning_when_noLoadingOfListeFailed.html is excluded by !**/visual logic/**.html
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/__snapshots__/TheUngueltigeWahlscheineVerifyCard.vue/visual logic/should_renderWithRequiredErrorMessage_when_wahlscheinNummerInputIsSetEmpty.html is excluded by !**/visual logic/**.html

📒 Files selected for processing (2)

• wls-gui-wahllokalsystem/src/components/wahlhandlung/TheUngueltigeWahlscheineVerifyCard.vue
• wls-gui-wahllokalsystem/tests/components/wahlhandlung/TheUngueltigeWahlscheineVerifyCard.spec.ts