fix(metadata): PSGS-934 fixed broken TxMetadataOut json decoder#59
fix(metadata): PSGS-934 fixed broken TxMetadataOut json decoder#59mpskowron wants to merge 1 commit into
Conversation
adamsmo
left a comment
adamsmo
left a comment
There was a problem hiding this comment.
This will create corner cases and create dependency in our code on the exact implementation that is provided by wallet
We discussed it yesterday, one option was to return metadata provided as input, another one was to just ask graphql for the metadata of mined transaction, in both cases there is no changes done in psg in the JSON
|
what prevents you from just calling getMetadata() ? |
|
Looks like tests are failing because of not enough funds on the wallet |
Probably nothing, after that first solution didn't work, I've seen that I might have hard time fixing tests if I won't fix the decoder, thus thought that it will be done faster if I do it. I might have been wrong with that. I also thought about how unstable GraphQl, thus not using it might give user a better experience. I get your point about more corner cases. I'll just call that getMetadata if parsing json fails - this seems like the best solution. What do you think? |
2 participants
No description provided.