Skip to content

Raph@cost estimation#61

Closed
rrtoledo wants to merge 7 commits into
mainfrom
raph@cost-estimation
Closed

Raph@cost estimation#61
rrtoledo wants to merge 7 commits into
mainfrom
raph@cost-estimation

Conversation

@rrtoledo

@rrtoledo rrtoledo commented May 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@rrtoledo rrtoledo requested a review from dkaidalov May 5, 2026 13:41
@rrtoledo rrtoledo self-assigned this May 5, 2026
@rrtoledo rrtoledo marked this pull request as draft May 5, 2026 13:41
/// All counts are lower bounds: they assume the minimal rotation set {prev, current, next}.
/// Blinding factors are derived from the maximum advice rotation depth across gates and arguments:
/// gates contribute `Arith::NB_EVAL_POINTS`, permutation 2, lookups 3.
pub fn estimate_verifier_code<PCS>(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the entry point for evaluating the circuit from params? I would suggest to add some high-level docs (maybe in repo README) showcasing how to use it.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@rrtoledo

rrtoledo commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

Halo2 not being properly maintained, and the cost-estimator functionalities already being in midnight-zk branch, we close this PR.

@rrtoledo rrtoledo closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants