Skip to content

fix(crypto): bump libsodium wrappers for ESM imports #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AngelCastilloB merged 1 commit into from
May 27, 2026
+15 −15
Merged

fix(crypto): bump libsodium wrappers for ESM imports #1683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/crypto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"@cardano-sdk/util": "workspace:~",
"blake2b": "^2.1.4",
"i": "^0.3.7",
"libsodium-wrappers-sumo": "0.7.10",
"libsodium-wrappers-sumo": "0.8.4",
"lodash": "^4.17.21",
"pbkdf2": "^3.1.3",
"ts-custom-error": "^3.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/crypto/src/Bip32/Bip32PublicKey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class Bip32PublicKey {

/** Gets the blake2 hash of the key. NOTE: You must await `Crypto.ready()` at least once before calling this function. */
hash(): Bip32PublicKeyHashHex {
const hash = sodium.crypto_generichash(BIP32_PUBLIC_KEY_HASH_LENGTH, this.#key);
const hash = sodium.crypto_generichash(BIP32_PUBLIC_KEY_HASH_LENGTH, this.#key, null);
return Bip32PublicKeyHashHex(Buffer.from(hash).toString('hex'));
}
}
2 changes: 1 addition & 1 deletion packages/crypto/src/Ed25519e/Ed25519PublicKey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class Ed25519PublicKey {

/** Gets the blake2 hash of the key material. NOTE: You must await `Crypto.ready()` at least once before calling this function. */
hash(): Ed25519KeyHash {
const hash = sodium.crypto_generichash(ED25519_PUBLIC_KEY_HASH_LENGTH, this.#keyMaterial);
const hash = sodium.crypto_generichash(ED25519_PUBLIC_KEY_HASH_LENGTH, this.#keyMaterial, null);
return Ed25519KeyHash.fromBytes(hash);
}

Expand Down
4 changes: 2 additions & 2 deletions yarn-project.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,8 +1670,8 @@ cacheEntries = {
"libnpmaccess@npm:7.0.2" = { filename = "libnpmaccess-npm-7.0.2-57b91bfda5-73d49f3939.zip"; sha512 = "73d49f39391173276c46c12e32f503709338efd867d255d062ae9bc9e9f464d61240747f42bdd6dc6003a5dc275a27352ebfc11ed4cb424091463f302d823f23"; };
"libnpmpublish@npm:7.1.3" = { filename = "libnpmpublish-npm-7.1.3-5c85223e00-585902f510.zip"; sha512 = "585902f5105b0e6647992d10dcea72373e8475f3bf279f3ba7264521568d90863c910355966d71e1407d3203945c995c2601a243df86578431cce1566e686070"; };
"libphonenumber-js@npm:1.10.18" = { filename = "libphonenumber-js-npm-1.10.18-154a7b087a-df0a4b8adf.zip"; sha512 = "df0a4b8adfb79666636913f6da730ffc3bc037094e35be492d2f7a23ef26754d65a7afa5f64e04f5c5c2883193fa10bd4bea966fd28edcf0c72ddd13bd4b3625"; };
"libsodium-sumo@npm:0.7.10" = { filename = "libsodium-sumo-npm-0.7.10-a21fe7b00e-67ed75fa15.zip"; sha512 = "67ed75fa15559bad7cca5cdc2d5eb20725281be38a08814f7e39af8ea0c0d83ed2211e534f7b47460b6a48a1f7bb5c31759e4bc5cc79fb74292ffea8f90ee741"; };
"libsodium-wrappers-sumo@npm:0.7.10" = { filename = "libsodium-wrappers-sumo-npm-0.7.10-51c142ca41-f1ff2599e9.zip"; sha512 = "f1ff2599e9ec6271a0ba9ee6a8ad940b9a7dbd1d14c6cb87f2e34e7c6d43f7f4622a1f432e5254875e0cae7d56b1de8697a3989b118f49959639f48f0268db88"; };
"libsodium-sumo@npm:0.8.4" = { filename = "libsodium-sumo-npm-0.8.4-3c5914becc-ba95071a06.zip"; sha512 = "ba95071a063c72330721b4ff7bc6b41321441f376f44203825dc4464cb88198cab941d54e03cdcba440af8754589eeb925fc82269fdced60f5c12c1a86227eb3"; };
"libsodium-wrappers-sumo@npm:0.8.4" = { filename = "libsodium-wrappers-sumo-npm-0.8.4-7827a76857-c6123e68f1.zip"; sha512 = "c6123e68f18902bbbd982ddc1b1c5b118626313104933e9de97ae8bf9cf300fee02d924758496fefe07567f3314bdd51aaddef61d40d9cdd3efac881e1db25f1"; };
"lie@npm:3.1.1" = { filename = "lie-npm-3.1.1-91350720d9-6da9f2121d.zip"; sha512 = "6da9f2121d2dbd15f1eca44c0c7e211e66a99c7b326ec8312645f3648935bc3a658cf0e9fa7b5f10144d9e2641500b4f55bd32754607c3de945b5f443e50ddd1"; };
"lighthouse-logger@npm:1.3.0" = { filename = "lighthouse-logger-npm-1.3.0-3f60201e4a-82655f1862.zip"; sha512 = "82655f1862779dc5a917de62567a23dbf47bbde9a53abbdd4d72b2cf80d6c2595bc84de7ef836c94c76a2e4e3f3ec613a2e1ec021367959d397aeb5aae97a7cb"; };
"lightstep-tracer@npm:0.31.2" = { filename = "lightstep-tracer-npm-0.31.2-3829fcb8e9-bbfc20aa46.zip"; sha512 = "bbfc20aa46e9884cb70b5a56a8eb59325e957ea4862954902dbf6203b955394b16ce989251cea6481c589b0a0d23ad43c2f5598a4ce7188d8adf91bb3df13cdc"; };
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2339,7 +2339,7 @@ __metadata:
eslint: ^7.32.0
i: ^0.3.7
jest: ^28.1.3
libsodium-wrappers-sumo: 0.7.10
libsodium-wrappers-sumo: 0.8.4
lodash: ^4.17.21
madge: ^5.0.1
npm-run-all: ^4.1.5
Expand Down Expand Up @@ -16955,19 +16955,19 @@ __metadata:
languageName: node
linkType: hard

"libsodium-sumo@npm:^0.7.0":
version: 0.7.10
resolution: "libsodium-sumo@npm:0.7.10"
checksum: 67ed75fa15559bad7cca5cdc2d5eb20725281be38a08814f7e39af8ea0c0d83ed2211e534f7b47460b6a48a1f7bb5c31759e4bc5cc79fb74292ffea8f90ee741
"libsodium-sumo@npm:^0.8.0":
version: 0.8.4
resolution: "libsodium-sumo@npm:0.8.4"
checksum: ba95071a063c72330721b4ff7bc6b41321441f376f44203825dc4464cb88198cab941d54e03cdcba440af8754589eeb925fc82269fdced60f5c12c1a86227eb3
languageName: node
linkType: hard

"libsodium-wrappers-sumo@npm:0.7.10":
version: 0.7.10
resolution: "libsodium-wrappers-sumo@npm:0.7.10"
"libsodium-wrappers-sumo@npm:0.8.4":
version: 0.8.4
resolution: "libsodium-wrappers-sumo@npm:0.8.4"
dependencies:
libsodium-sumo: ^0.7.0
checksum: f1ff2599e9ec6271a0ba9ee6a8ad940b9a7dbd1d14c6cb87f2e34e7c6d43f7f4622a1f432e5254875e0cae7d56b1de8697a3989b118f49959639f48f0268db88
libsodium-sumo: ^0.8.0
checksum: c6123e68f18902bbbd982ddc1b1c5b118626313104933e9de97ae8bf9cf300fee02d924758496fefe07567f3314bdd51aaddef61d40d9cdd3efac881e1db25f1
languageName: node
linkType: hard

Expand Down
Loading