fix: respect pagination limit in credential queries#1671
Merged
Conversation
…based transaction queries When queryTxsByCredentials is enabled, fetchTransactionsByPaymentCredential and fetchTransactionsByRewardAccount were fetching ALL pages from Blockfrost instead of stopping once enough transactions were retrieved. This caused unnecessary API calls and performance issues. Changes: - Add FetchTransactionsOptions interface to document and deduplicate options - Implement proper haveEnoughItems logic (was: () => false, now: checks limit) - Extract common pagination logic into fetchTransactionsWithPagination - Pass limit parameter through the call chain - Cap page size at 100 (Blockfrost's max) to enable proper pagination The fix ensures credential-based queries behave identically to address-based queries, fetching only the necessary pages to satisfy the requested limit.
…rom UTXO queries The haveEnoughItems parameter with value () => false is redundant in fetchUtxosByPaymentCredential and fetchUtxosByRewardAccount. When not specified, fetchSequentially defaults to fetching all pages, which is the correct behavior for UTXO queries (they should return all UTXOs). This aligns credential-based UTXO queries with the by-address reference implementation which also omits haveEnoughItems.
ljagiela
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
See commit messages