feat(web-extension): support wallet-specific trezorConfig in SigningC…#1666
Merged
Conversation
rhyslbw
force-pushed
the
feat/web-extension-derivation-type
branch
from
0f06b37 to
0389e54
Compare
mkazlauskas
previously approved these changes
Sep 17, 2025
mkazlauskas
left a comment
mkazlauskas
left a comment
Member
There was a problem hiding this comment.
Looks good! Just some minor concerns 👇
…d Trezor types - Split HardwareWallet into LedgerHardwareWallet and TrezorHardwareWallet - Maintains backward compatibility through union type - Prepares for wallet-specific configuration support
rhyslbw
force-pushed
the
feat/web-extension-derivation-type
branch
from
deea40f to
2ed63c0
Compare
- Add trezorConfig to wallet metadata for TrezorHardwareWallet - Update SigningCoordinator to read trezorConfig from wallet.metadata - Add minimal test to verify trezorConfig functionality - Ensures trezorConfig can be updated via wallet manager and persists properly - Supports both wallet-specific trezorConfig and global hwOptions fallback
rhyslbw
force-pushed
the
feat/web-extension-derivation-type
branch
from
2ed63c0 to
895453d
Compare
…nator#signRequest - Extract #findAccount method for account lookup logic - Extract #createInMemorySignRequest for in-memory wallet sign requests - Extract #createHardwareSignRequest for hardware wallet sign requests - Extract #createHardwareKeyAgent for key agent creation logic - Replace complex nested ternary with simple conditional - Add proper TypeScript types for Bip32WalletAccount - Remove eslint-disable comment for cognitive complexity - Maintain exact same functionality while improving readability
rhyslbw
force-pushed
the
feat/web-extension-derivation-type
branch
from
895453d to
34d9d35
Compare
mkazlauskas
approved these changes
Sep 18, 2025
| request: Omit<Req, 'reject' | 'sign'>, | ||
| sign: (keyAgent: KeyAgent) => Promise<R> | ||
| ) { | ||
| /* eslint-disable sonarjs/cognitive-complexity */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Continues the support for Trezor
derivationTypein the web-extension interface