Skip to content

Feat/fix trezor signing#1652

Merged
rhyslbw merged 3 commits into
masterfrom
feat/fix-trezor-signing
Sep 9, 2025
Merged

Feat/fix trezor signing#1652
rhyslbw merged 3 commits into
masterfrom
feat/fix-trezor-signing

Conversation

@AngelCastilloB

@AngelCastilloB AngelCastilloB commented Sep 9, 2025

Copy link
Copy Markdown
Member

Context

  • Fix a bug that was causing the Ledger and Trezor key agents to incorrectly flag an ordinary transaction as multisig transactions.
  • Trezor key agent now correctly sets the includeNetworkId (depending on whether the transaction has the networkId field set or not)

Comment thread packages/hardware-trezor/src/transformers/tx.ts
rhyslbw
rhyslbw previously approved these changes Sep 9, 2025

@rhyslbw rhyslbw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AngelCastilloB

mkazlauskas
mkazlauskas previously approved these changes Sep 9, 2025
Comment thread packages/hardware-ledger/src/LedgerKeyAgent.ts Outdated
@rhyslbw rhyslbw dismissed stale reviews from mkazlauskas and themself via 98230e2 September 9, 2025 14:26
@rhyslbw rhyslbw force-pushed the feat/fix-trezor-signing branch from 64af01d to 98230e2 Compare September 9, 2025 14:26
@rhyslbw rhyslbw force-pushed the feat/fix-trezor-signing branch from 98230e2 to 92b19e2 Compare September 9, 2025 14:28
@rhyslbw rhyslbw self-requested a review September 9, 2025 14:59
@rhyslbw rhyslbw merged commit 5b4680d into master Sep 9, 2025
10 of 11 checks passed
@rhyslbw rhyslbw deleted the feat/fix-trezor-signing branch September 9, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants