fix: use actual address size for min value computation#1639
Merged
Conversation
…OutputValidator minimum coin quantity depends on type of address (Byron addresses are larger) validating a Value without knowing an address is prone to bugs, where one might assume that it's a Shelley address. If that is in fact what is needed, then it's better to explicitly use some stub address.
… 'describe' in order to make tests more readable, e.g. 'it validates' vs 'it output validator validates'
…tion param OutputValidator.validateOutput used a stub shelley address, which computed an invalid minimum coin quantity for outputs to Byron address that are larger in bytes, therefore actually requiring more coins than computed
mirceahasegan
approved these changes
Jul 4, 2025
mirceahasegan
left a comment
mirceahasegan
left a comment
Collaborator
There was a problem hiding this comment.
Fantastic work @mkazlauskas 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
OutputValidator.validateOutputreturns incorrect minimum coin quantity for outputs to Byron addressLW-13214
Proposed Solution
See commit messages
Important Changes Introduced