fix: fix long message signing on ledger#1636
Merged
AngelCastilloB merged 1 commit intoJun 25, 2025
Merged
Conversation
AngelCastilloB
requested review from
iccicci,
mirceahasegan,
mkazlauskas and
rhyslbw
and removed request for
mirceahasegan
iccicci
approved these changes
Jun 25, 2025
iccicci
left a comment
iccicci
left a comment
Contributor
There was a problem hiding this comment.
Minimal and effective: excellent!
mirceahasegan
approved these changes
Jun 25, 2025
mirceahasegan
left a comment
mirceahasegan
left a comment
Collaborator
There was a problem hiding this comment.
Great work @AngelCastilloB 🚀
AngelCastilloB
deleted the
fix/LW-13126-fix-large-message-signing-on-ledger
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We are unable to sign long messages with the CIP-08 sign message function on ledger, this is because ledger has limited memory. For longer messages (as per CIP-08 spec) we must switch to sign the hashed message.
Proposed Solution
Detect the length of the message being signed and switch to hashed message if >= 100 in length.