Skip to content

LW-13058 Fix flaky test in koralabs handle provider#1635

Merged
iccicci merged 1 commit into
masterfrom
test/kora-labs
Jun 13, 2025
Merged

LW-13058 Fix flaky test in koralabs handle provider#1635
iccicci merged 1 commit into
masterfrom
test/kora-labs

Conversation

@iccicci

@iccicci iccicci commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Context

The KoraLabsHandleProvider test directly calls the public API, so they are subjected to flakiness due to network errors or handles metadata changes.

Proposed Solution

Used a mock.

AngelCastilloB
AngelCastilloB previously approved these changes Jun 12, 2025

@AngelCastilloB AngelCastilloB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iccicci ❤️

@mirceahasegan mirceahasegan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾

@iccicci iccicci merged commit 1e1b1ba into master Jun 13, 2025
10 of 12 checks passed
@iccicci iccicci deleted the test/kora-labs branch June 13, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants