fix: fix native script singing#1633
Merged
Merged
Conversation
iccicci
reviewed
Jun 5, 2025
iccicci
left a comment
iccicci
left a comment
Contributor
There was a problem hiding this comment.
I feel not strong enough on this topic to provide a valuable review. I just left a minor comment.
Member
Author
Thanks @iccicci, I also have some lint errors on some unit test, will fix those and apply your change request |
AngelCastilloB
force-pushed
the
feat/fix-native-script-signing-with-hw
branch
from
a8ad1da to
9286c0e
Compare
mirceahasegan
approved these changes
Jun 5, 2025
mirceahasegan
left a comment
mirceahasegan
left a comment
Collaborator
There was a problem hiding this comment.
Fantastic work @AngelCastilloB 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Our integration with hardware wallets and transactions with native scripts had a few gaps/bugs that was preventing us from signing correctly multiSig transactions with ledger or trezor.