fix(youtube): support click+hold interactions as user-intentional rate-changes#1555
Open
Tredecate wants to merge 1 commit into
Open
Conversation
YouTube supports click-and-hold to set a temporary speed, but fight-back overrode the change due to lastUserInteractionAt using click events. Now clickHandler fires on pointerdown too, setting lastUserInteractionAt and a new isClickHeld flag that is checked alongside timeSinceGesture. Fixes igrigorik#1554
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adjusts the handling of user gesture tracking in the
EventManagerclass to support click-and-hold interactions with site controls. Fixes #1554Why
YouTube allows users to click-and-hold for a temporary 2x speed boost, but
handleRateChange()was overriding the update due tolastUserInteractionAtonly usingclickevents to detect mouse interactions.As
clickonly fires after an entire mouse-down -> mouse-up cycle completes,lastUserInteractionAtwasn't being set until after the user released the button press. Now,clickHandleris called onpointerdown, too, settinglastUserInteractionAtand updating a newisClickHeldflag that is included inhandleRateChange()'s logic.How
isClickHeldproperty toEventManagerto track whether the most recent mouse interaction is currently held down.isClickHeldis updated based on the most recentevent.typereceived byclickHandler.pointerdownevent listener to pair with the existingclicklistener forclickHandler.