Add in Integration with Firewall extension

[seamuslee001]

This adds a condiditional integration with the Firewall to trigger specific events within that firewall when Iats issues a decline

[adixon]

Thanks for this, three thoughts ...

1. That seems like a lot of duplicated code in each of the payment processors - how about a single static function that lives in the utils object that can be a single invocation line for each of the processors?
2. You're assuming the "error" function in the payment processors are all invoked due to card issues? Aren't there other reasons code flow would end up here? You might be right, and it's weird that I'm asking the question, but I'm lazy and have a short memory.
3. Great to see support in the firewall extension for reverse proxies! Now we just have to get that into core?

[mattwire]

@seamuslee001 linking https://lab.civicrm.org/extensions/mjwshared/-/merge_requests/49 for reference

[shaneonabike]

@seamuslee001 thanks for your work on this!

I think for the most part this is pretty good. @adixon I'm not sure how any of this could be put into the Firewall extension, because the actions are dependent on failures in the payment processor. I had to add this manually for one client that was getting CC spammed. I think it's on the rise so if we could get this in somehow that would be great.

[shaneonabike]

@seamuslee001 thanks for your work on this!

I think for the most part this is pretty good. @adixon I'm not sure how any of this could be put into the Firewall extension, because the actions are dependent on failures in the payment processor. I had to add this manually for one client that was getting CC spammed. I think it's on the rise so if we could get this in somehow that would be great.

[mattwire]

@seamuslee001 thanks for your work on this!

I think for the most part this is pretty good. @adixon I'm not sure how any of this could be put into the Firewall extension, because the actions are dependent on failures in the payment processor. I had to add this manually for one client that was getting CC spammed. I think it's on the rise so if we could get this in somehow that would be great.

@shaneonabike I linked that quickly without explanation. What I should have said is that we were looking at a shared way to support both firewall and moat extensions automatically without having to write code for both.

[adixon]

What I'd prefer is a method CRM_Iats_Utils::firewallEvent(string $error, string $label, array $fraud = []) that could be called as firewallEvent($error, 'Iats Faps error') for the convertParams function, and as firewallEvent($error, 'Iats Service error', ['tumbling', 'stolen']), etc. for the error functions. Is that too much to ask?