Join room by maayamohan · Pull Request #27 · homebrew-ec-foss/JamSesh

maayamohan · 2025-08-18T06:17:05Z

Room Logic

Which issue(s) does this PR address?

Implementation of room logc

Why do we need this PR?

We need rooms

What logical changes are present in this PR?

Separating client-side code into host and join relevant files.

How did you test the changes in this PR?

I didnt

Are there any breaking changes in this PR?

Maybe

Is there some additional work to be done later that is NOT covered in this PR?

server.js needs some changes to accomodate rooms

…cturefeat: add signaling and vid call

Co-authored-by: Srivani Karanth <karanthsrivani@gmail.com> * feat:insert API endpoint * feat: added auto bitrate * feat:insert API endpoint * feat: added auto bitrate

Co-authored-by: SolarPhoenix13 <tisyaagarwal2007@gmail.com> Co-authored-by: Maaya Mohan <maayamohan21@gmail.com>

Co-authored-by: Vanshitha <vanshitha.s@gmail.com>

maayamohan · 2025-08-18T06:18:05Z

Room Logic

Which issue(s) does this PR address?

Implementation of room logc

Why do we need this PR?

We need rooms

What logical changes are present in this PR?

Separating client-side code into host and join relevant files.

How did you test the changes in this PR?

I didnt

Are there any breaking changes in this PR?

Maybe

Is there some additional work to be done later that is NOT covered in this PR?

server.js needs some changes to accomodate rooms

@mebinthattil @Andy34G7 @Delta18-Git please check this whenever you can

mebinthattil

I have shared my feedback after a quick scan and tests. Please resolve those issues.
Excited to see where y'all take it from here!

Requesting review from @Delta18-Git & @Andy34G7 as well.

Delta18-Git · 2025-08-19T11:19:31Z

Will be reviewing in 30 minutes, thanks for the ping.

EDIT: 4 hrs later the review is complete, my bad 😞

Delta18-Git

Feel like its a good start, but since the server code is not present no real way of tracing the logic completely yet. Also quite confusing that Maaya has been the only one working on this.

Delta18-Git · 2025-08-19T14:24:32Z

+  <style>
+    body {
+      background-color: #152238;
+      color: white;
+      font-family: 'Fjalla One', sans-serif;
+      display: flex;
+      flex-direction: column;
+      align-items: center;
+      justify-content: center;
+      height: 100vh;
+    }
+
+    h1 {
+      font-size: 60px;
+      margin-bottom: 40px;
+    }
+
+    button {
+      padding: 14px 28px;
+      font-size: 22px;
+      border: none;
+      border-radius: 10px;
+      background-color: #0F52BA;
+      color: white;
+      cursor: pointer;
+      margin-top: 20px;
+      transition: background-color 0.3s;
+    }
+
+    button:hover {
+      background-color: #0c47a1;
+    }
+
+    #jamCodeDisplay {
+      font-size: 28px;
+      margin-top: 20px;
+      color: #00ffff;
+    }
+
+    #enterRoomHostBtn {
+      display: none;
+    }
+
+    a {
+      position: absolute;
+      top: 20px;
+      left: 20px;
+      color: #00ffff;
+      text-decoration: none;
+      font-size: 18px;
+    }
+  </style>


I think it makes sense to move the CSS to a separate file which is imported as there is a lot of shared loc in these webpages.

Same comment applies for all other pages.

updated version with a lighter hover effect as mebin mentioned

another update regarding buttons

…join-room

mebinthattil

@SolarPhoenix13
I see that you have created two commits both named update index.html, you could have squashed both those commits into a single commit named 'updating index.html to solve excessive glow animation on JamSesh text.'

Just a suggestion for your future commits.

… into server-logic

feat: integrate timesync barebones

Delta18-Git

These are some minor changes that I've found. Good work, perhaps look into how you can reduce the latency as timesync seems to not have helped much.

Delta18-Git · 2025-12-24T13:58:59Z

@@ -1,92 +1,82 @@
 <!DOCTYPE html>


Using LocalStorage/Cookie instead of query parameters makes more sense to me here.

Delta18-Git · 2025-12-24T13:59:57Z

@@ -0,0 +1,189 @@
+<!DOCTYPE html>


This JS <script> would be better off imported, it gets a bit too complicated here.

Delta18-Git · 2025-12-24T14:01:07Z

-
 const init = () => {
-    ws = new WebSocket("ws://localhost:8080");
+    ws = new WebSocket("wss://jamsesh-8wui.onrender.com");


This should not be hardcoded ideally

Delta18-Git · 2025-12-24T14:01:56Z

+                window.currentClientId = clientId;
+            }
+            // The roomCode is searched on load
+            const urlParams = new URLSearchParams(window.location.search);


This should be trivial to move to LocalStorage or a cookie.

Delta18-Git · 2025-12-24T14:02:31Z

+            const leftClientId = leavingParticipant.id;
+            console.log(`Client ${leavingParticipant.username} (${leftClientId}) left.`);
+            allParticipants = allParticipants.filter(p => p.id !== leftClientId);
+            if (typeof window.updateParticipantList === 'function') {


Why would it be possible to overwrite this to not be a function?

Delta18-Git · 2025-12-24T14:03:32Z

+startBtn.disabled = true;
+
+const init = () => {
+    ws = new WebSocket("wss://jamsesh-8wui.onrender.com");


This is again hardcoded, when it shouldn't be.

Delta18-Git · 2025-12-24T14:05:20Z

@@ -0,0 +1,378 @@
+function loadScript(src) {


Check if TURN servers are avoided when they are not needed, or if they are used even without a NAT.

maayamohan and others added 17 commits August 10, 2025 08:39

docs: add pull request template (#10)adds a PR template for more stru…

e9f254b

…cturefeat: add signaling and vid call

feat: update index.html and PeerConnection.js

d0623c1

feat: Implement multi-user streaming changed server.js accordingly

25985a8

frontend

b1c2493

refactor: Moved client side script code to new file

ea90d7a

feat: Display room code and code input field

adbc6cb

feat: Implemented room logic

e640b91

refactor: Moved all html scripts to client.js

c16e947

chore: cleaning up client.js

44335ff

feat: add auto bitrate (#21)

ecc2391

Co-authored-by: Srivani Karanth <karanthsrivani@gmail.com> * feat:insert API endpoint * feat: added auto bitrate * feat:insert API endpoint * feat: added auto bitrate

chore: update index.html to previous state

0a2c007

Co-authored-by: SolarPhoenix13 <tisyaagarwal2007@gmail.com> Co-authored-by: Maaya Mohan <maayamohan21@gmail.com>

chore: remove unnecessary files

8fd826d

Co-authored-by: Vanshitha <vanshitha.s@gmail.com>

chore: Added navigation.js to handle all page navigations

bd8aa0b

refactor: Moved host relevant code to host.js

6f18056

fix: Fixed enter room button display condition for join

73a6c43

refactor: Moved join relevant code to join.js

cc934ad

fix: Made fixes in host.js

cd68ec4

Andy34G7 requested review from Andy34G7, Delta18-Git and mebinthattil August 18, 2025 07:32

mebinthattil requested changes Aug 18, 2025

View reviewed changes

Comment thread public/js/navigation.js Outdated

Comment thread public/js/navigation.js Outdated

Comment thread public/page2.html Outdated

Comment thread public/page2.html Outdated

Delta18-Git requested changes Aug 19, 2025

View reviewed changes

SolarPhoenix13 and others added 6 commits August 19, 2025 22:25

Update index.html

57db5c1

updated version with a lighter hover effect as mebin mentioned

Update index.html

f6803d3

another update regarding buttons

fix: Fixed script source file name in page2.html

8c07ed3

Merge branch 'join-room' of github.com:homebrew-ec-foss/JamSesh into …

bd5b007

…join-room

refactor: Added comments for the code blocks

8028359

refactor: Refactor in host.js

0a6694c

mebinthattil reviewed Aug 22, 2025

View reviewed changes

maayamohan and others added 10 commits August 23, 2025 07:58

fix: Removed reinitialisation of ws in navigation.js

4bc47e9

feat: Sending start-call message from host.js

0b6e44d

feat: Added room-code validation from the server

e975302

fix: Disable start call button till host starts call

5a362d9

Merge branch 'join-room' of https://github.com/homebrew-ec-foss/JamSesh…

3ee626b

… into server-logic

feat: Added working room logic for multiple rooms

ca86979

fix: Wrong api end point

c6b4ba1

feat: Added more user friendly UI-UX

00f3e05

fix: Made continous UI and fixed volume issues

2e4ee8e

fix: Bug in websocket link

9d0555d

Andy34G7 requested review from Delta18-Git and mebinthattil August 27, 2025 06:34

vanshsoma and others added 5 commits August 27, 2025 20:45

fix: Uptime ping

547b544

feat: integrate timesync for sync playback (#28)

f994303

feat: integrate timesync barebones

fix: Installed dependencies

9c24a33

fix: clients not receiving stream

0f5f316

fix: rechecks latency every 5s

c0c226f

Delta18-Git reviewed Dec 24, 2025

View reviewed changes

Uh oh!

Conversation

maayamohan commented Aug 18, 2025

Room Logic

Which issue(s) does this PR address?

Why do we need this PR?

What logical changes are present in this PR?

How did you test the changes in this PR?

Are there any breaking changes in this PR?

Is there some additional work to be done later that is NOT covered in this PR?

Uh oh!

maayamohan commented Aug 18, 2025

Room Logic

Which issue(s) does this PR address?

Why do we need this PR?

What logical changes are present in this PR?

How did you test the changes in this PR?

Are there any breaking changes in this PR?

Is there some additional work to be done later that is NOT covered in this PR?

Uh oh!

mebinthattil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Delta18-Git commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Delta18-Git left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mebinthattil left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Delta18-Git left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Delta18-Git commented Aug 19, 2025 •

edited

Loading

mebinthattil left a comment •

edited

Loading