Skip to content

chore: drop stale flexsearch optimizeDeps entry#840

Open
50rayn wants to merge 1 commit into
histoire-dev:mainfrom
50rayn:chore/remove-stale-flexsearch
Open

chore: drop stale flexsearch optimizeDeps entry#840
50rayn wants to merge 1 commit into
histoire-dev:mainfrom
50rayn:chore/remove-stale-flexsearch

Conversation

@50rayn

@50rayn 50rayn commented May 2, 2026

Copy link
Copy Markdown
Contributor

Search migrated to fuse.js in #770 (Vite 6 upgrade) but this include reference was missed. No runtime effect today; just dead code.

Closed #646 , #532

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify

netlify Bot commented May 2, 2026

Copy link
Copy Markdown

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 54e1a33
🔍 Latest deploy log https://app.netlify.com/projects/histoire-examples-svelte3/deploys/69f651a0e3bb4200080dd013
😎 Deploy Preview https://deploy-preview-840--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 2, 2026

Copy link
Copy Markdown

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 54e1a33
🔍 Latest deploy log https://app.netlify.com/projects/histoire-controls/deploys/69f651a0be87a5000830ef31
😎 Deploy Preview https://deploy-preview-840--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 2, 2026

Copy link
Copy Markdown

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 54e1a33
🔍 Latest deploy log https://app.netlify.com/projects/histoire-site/deploys/69f651a0c94da9000882b092
😎 Deploy Preview https://deploy-preview-840--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 2, 2026

Copy link
Copy Markdown

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 54e1a33
🔍 Latest deploy log https://app.netlify.com/projects/histoire-examples-vue3/deploys/69f651a0bbd90e000893732c
😎 Deploy Preview https://deploy-preview-840--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented May 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

histoire

npm i https://pkg.pr.new/histoire@840

@histoire/app

npm i https://pkg.pr.new/@histoire/app@840

@histoire/controls

npm i https://pkg.pr.new/@histoire/controls@840

@histoire/plugin-nuxt

npm i https://pkg.pr.new/@histoire/plugin-nuxt@840

@histoire/plugin-percy

npm i https://pkg.pr.new/@histoire/plugin-percy@840

@histoire/plugin-screenshot

npm i https://pkg.pr.new/@histoire/plugin-screenshot@840

@histoire/plugin-svelte

npm i https://pkg.pr.new/@histoire/plugin-svelte@840

@histoire/plugin-vue

npm i https://pkg.pr.new/@histoire/plugin-vue@840

@histoire/shared

npm i https://pkg.pr.new/@histoire/shared@840

@histoire/vendors

npm i https://pkg.pr.new/@histoire/vendors@840

commit: 54e1a33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes 'flexsearch' from the optimizeDeps inclusion list in the Vite configuration within packages/histoire/src/node/vite.ts. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning in build = Use of eval in flexsearch

1 participant