test: add HbarAllowance unit coverage#1708
Conversation
Signed-off-by: peter941221 <peter941221@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Hi, can you give me more info about this: |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Sure. This was a local full-suite observation, not a failure introduced by this PR. On my local Windows environment: I can reproduce the panic by running the existing test directly: go test ./sdk -tags="unit" -v -run TestUnitConcurrentGetNodeReadmit -count=10 -timeout 9999sIt fails with: I also reproduced the same failure on a clean so it does not appear to be related to the new The PR-specific test passes locally: go test ./sdk -tags="unit" -v -run TestUnitHbarAllowance -timeout 9999sAlso, I see the GitHub Actions |
|
can you raise an issue about this - you could also work on it if you want |
|
Opened #1714 to track it separately. I'll keep this PR focused on the HbarAllowance unit coverage. |
Summary
HbarAllowanceconstructor storageString()coverage for all four owner/spender nil combinationsValidation
GOPROXY=https://goproxy.cn,direct go test ./sdk -tags="unit" -v -run TestUnitHbarAllowance -timeout 9999sGOPROXY=https://goproxy.cn,direct go build ./...GOPROXY=https://goproxy.cn,direct golangci-lint runNotes
go test ./sdk -tags="unit" -v -timeout 9999scurrently fails in existingTestUnitConcurrentGetNodeReadmitwithpanic: failed to find a healthy working node.origin/mainmirror, so it is unrelated to this change.Fixes: #1705