feat: EthereumTransaction/Flow quality improvements#1336
Merged
0xivanov merged 8 commits intoMay 8, 2025
Merged
Conversation
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
0xivanov
changed the title
EthereumTransaction/Flow quality improvementsEthereumTransaction/Flow quality improvements
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
…eumTransactionData
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
approved these changes
May 8, 2025
0xivanov
deleted the
1329-Expose-GetCallData/SetCallData-in-EthereumTransactionData
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
EthereumTransactionData.CallDataAccessEthereumFlowresponse access. When using EthereumFlow.Execute(), if the transaction fails, return the responseRelated issue(s):
Fixes #1329
Notes for reviewer:
Checklist