Add CreatedOn Property to Scan Output#253
Merged
Merged
Conversation
Contributor
Author
|
DO NOT MERGE YET Dependent on deployment of API change |
KLongmuirHD
force-pushed
the
add_date_created_to_report
branch
from
June 9, 2025 13:01
20b7617 to
884e1db
Compare
KLongmuirHD
marked this pull request as ready for review
June 9, 2025 16:05
Contributor
Author
|
Required API changes have been deployed to Stage and Prod, no longer blocked. |
KLongmuirHD
force-pushed
the
add_date_created_to_report
branch
3 times, most recently
from
June 9, 2025 19:13
bc4b285 to
2bd49f8
Compare
edezekiel
reviewed
Jun 9, 2025
edezekiel
approved these changes
Jun 9, 2025
edezekiel
left a comment
edezekiel
left a comment
Contributor
There was a problem hiding this comment.
Approved, but please add a e2e spec and get the tests passing in ci. If there's an unrelated reason why the specs are failing please let me know and I'll take a look
KLongmuirHD
force-pushed
the
add_date_created_to_report
branch
2 times, most recently
from
June 10, 2025 12:41
3d17979 to
8bce926
Compare
KLongmuirHD
force-pushed
the
add_date_created_to_report
branch
2 times, most recently
from
June 10, 2025 14:47
340a0af to
0dc5c8f
Compare
rlmestre
approved these changes
Jun 10, 2025
KLongmuirHD
force-pushed
the
add_date_created_to_report
branch
from
June 11, 2025 12:01
0dc5c8f to
e6f79b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/neverendingsupport/data-and-integrations/issues/84