Fix std in the summary statistics#360
Merged
guillermo-navas-palencia merged 2 commits intoJun 3, 2025
Merged
Conversation
Owner
|
Very nice work! Thanks for looking at it. |
guillermo-navas-palencia
approved these changes
Jun 3, 2025
Owner
|
I think this branch must be updated with develop to pass the tests. |
3eb7a34
into
guillermo-navas-palencia:develop
12 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Guillermo,
This PR fixes #324.
When$y^2$ instead of
sample_weightis provided, thessumcalculation needs to multiply the weight afterymask(multiply weight first and then take the square). It is related with #323 at some level (both are about sample weight) but needs a separate fix.where s_ssums =$\sum w_i y_i^2$ .
I used the test code in #324 to test the fix. Row 3 (group [8.5, 9.5)) now has std=0 as expected.
Before

After
