Skip to content

Return expected number of values in compute_prebins for ContinuousOptimalBinning #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillermo-navas-palencia merged 3 commits into from
Jun 3, 2025
Merged

Return expected number of values in compute_prebins for ContinuousOptimalBinning #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b1329
return expected 8 number of items instead of 3
YC-1412 May 28, 2025
0374492
increase test piecewise tolerance to 1e-4. See details in https://git…
YC-1412 Jun 2, 2025
9d34b08
increase test piecewise tolerance to 1e-4. See details in https://git…
YC-1412 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion optbinning/binning/continuous_binning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,7 +897,8 @@ def _prebinning_refinement(self, splits_prebinning, x, y, y_missing,
def _compute_prebins(self, splits_prebinning, x, y, sw):
n_splits = len(splits_prebinning)
if not n_splits:
return splits_prebinning, np.array([]), np.array([])
return (splits_prebinning, np.array([]), np.array([]), np.array([]),
np.array([]), np.array([]), np.array([]), np.array([]))

if self.dtype == "categorical" and self.user_splits is not None:
indices = np.digitize(x, splits_prebinning, right=True)
Expand Down
3 changes: 1 addition & 2 deletions tests/test_binning_piecewise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,7 @@ def test_default_discontinuous():
optb.fit(x, y)

optb.binning_table.build()
assert optb.binning_table.iv == approx(5.84465825, rel=1e-6)

assert optb.binning_table.iv == approx(5.84465825, rel=1e-4)

def test_bounds_transform():
optb = OptimalPWBinning(name=variable)
Expand Down