Skip to content

test: add python MCP bootstrap spec#1457

Merged
zeitlinger merged 2 commits into
tempo-mcpfrom
codex/python-mcp-spec-stacked
Jun 11, 2026
Merged

test: add python MCP bootstrap spec#1457
zeitlinger merged 2 commits into
tempo-mcpfrom
codex/python-mcp-spec-stacked

Conversation

@zeitlinger

Copy link
Copy Markdown
Member

What changed

  • add docker/mcp-bootstrap-spec.py as a small Python spec for the MCP bootstrap behavior
  • refactor docker/run-all.bats to compare run-all.sh output and generated artifacts against that spec
  • keep the existing docs/path checks while replacing the repetitive MCP matrix assertions with spec-based checks

Why it changed

The MCP bootstrap behavior in docker/run-all.sh is easy to drift as the matrix grows. This keeps the runtime implementation in shell, but moves the expected behavior model into a compact, testable Python script that acts as a second implementation for the tests.

User impact

No runtime behavior change. This only strengthens tests for the Tempo/Grafana MCP bootstrap combinations.

Validation

  • python3 -m py_compile docker/mcp-bootstrap-spec.py
  • bats docker/run-all.bats
  • bats docker/run-otelcol.bats docker/run-all.bats

Stacked on top of #1385 via base branch tempo-mcp.

@zeitlinger zeitlinger force-pushed the codex/python-mcp-spec-stacked branch from 52d24de to 8d3a440 Compare June 8, 2026 16:55
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger force-pushed the codex/python-mcp-spec-stacked branch from 8d3a440 to 7650ab6 Compare June 9, 2026 08:23
@zeitlinger zeitlinger marked this pull request as ready for review June 9, 2026 08:30
@zeitlinger zeitlinger requested a review from a team as a code owner June 9, 2026 08:30
@zeitlinger zeitlinger requested a review from martincostello June 9, 2026 08:30
@martincostello

martincostello commented Jun 9, 2026

Copy link
Copy Markdown
Member

Stacked on top of #1385 via base branch tempo-mcp.

If this stacks, shouldn't this be left in draft? Or is the intention to close that PR and have this take both changes instead?

Never mind, I see this isn't merging to main.

Comment thread .github/workflows/ci.yml
@zeitlinger

Copy link
Copy Markdown
Member Author

Stacked on top of #1385 via base branch tempo-mcp.

If this stacks, shouldn't this be left in draft? Or is the intention to close that PR and have this take both changes instead?

Never mind, I see this isn't merging to main.

Yes - I thought it would be easier to review as stacked pr

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger merged commit 0ee958a into tempo-mcp Jun 11, 2026
14 checks passed
@zeitlinger zeitlinger deleted the codex/python-mcp-spec-stacked branch June 11, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants