Conversation
…EXT=1 ARBOR_ALLOW_PLAINTEXT=1 now bypasses the loopback-only check in addition to the cert-not-found check. This lets users bind to a VPN interface (e.g. WireGuard 10.x.x.x) with plain HTTP when the tunnel itself provides confidentiality, without needing a self-signed certificate. A WARNING is printed at startup; the error message for the default (unset) case now mentions ARBOR_ALLOW_PLAINTEXT=1 as the escape hatch. Documented in arbor.env.example under the VPN / private network section. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previously session and CSRF cookies always had Secure=True, causing browsers to reject them on plain-HTTP connections (e.g. VPN access without TLS termination). Now secure= follows request.url.scheme so cookies work on HTTP while remaining Secure on HTTPS. When behind a TLS-terminating proxy the scheme is rewritten to https via X-Forwarded-Proto (trusted proxy), so Secure is preserved there. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add Pattern C (ARBOR_ALLOW_PLAINTEXT=1 on WireGuard/VPN interface) to LAN access section, including Apache HTTP proxy example and the ProxyPassReverseCookiePath gotcha that causes duplicate cookies / CSRF failures - Update ARBOR_ALLOW_PLAINTEXT config table entry: now bypasses the loopback-only check, not just the cert-not-found check - Update cookie security note: Secure flag follows request.url.scheme, not hardcoded True - Update TLS bind enforcement note to mention the ALLOW_PLAINTEXT escape hatch Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n login FakeRequest lacked a .url attribute, causing AttributeError on the _secure = request.url.scheme == "https" line added for dynamic cookie Secure flag. Added url=SimpleNamespace(scheme="http") to FakeRequest and used getattr fallback in main.py for any other bare-request call sites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.