#5048 - Notifier les validateurs lorsqu'une entreprise sur leur convention est bannie#5217
Open
Hidden character warning
The head ref may contain hidden characters: "5048-etq-prescripteur-je-veux-\u00eatre-inform\u00e9-quune-entreprise-a-\u00e9t\u00e9-bannie-lorsque-jai-une-convention-sign\u00e9e-mais-dont-limmersion-nest-pas-termin\u00e9e"
Conversation
|
📌 Deploy a review app for this PR: ➡️ Click here to deploy review app When clicking the link above:
|
tpicaud
force-pushed
the
5048-etq-prescripteur-je-veux-être-informé-quune-entreprise-a-été-bannie-lorsque-jai-une-convention-signée-mais-dont-limmersion-nest-pas-terminée
branch
from
f71b4d9 to
0f07285
Compare
tpicaud
force-pushed
the
5048-etq-prescripteur-je-veux-être-informé-quune-entreprise-a-été-bannie-lorsque-jai-une-convention-signée-mais-dont-limmersion-nest-pas-terminée
branch
from
0f07285 to
cce0056
Compare
tpicaud
force-pushed
the
5048-etq-prescripteur-je-veux-être-informé-quune-entreprise-a-été-bannie-lorsque-jai-une-convention-signée-mais-dont-limmersion-nest-pas-terminée
branch
from
cce0056 to
4a2dc88
Compare
enguerranws
requested changes
Jun 25, 2026
| }, | ||
| followedIds: { establishmentSiret: siret }, | ||
| }), | ||
| await notifyValidatorsAndPreValidators( |
Contributor
There was a problem hiding this comment.
Suggested change
| await notifyValidatorsAndPreValidators( | |
| await notifyValidatorsAndCounsellors( |
On utilise counsellor normalement pour les prévalidateurs (je crois).
| }), | ||
| ); | ||
|
|
||
| const conventionsBeforeValidation = |
Contributor
There was a problem hiding this comment.
Je comprends pas ce conventionsBeforeValidation : on est d'accord que la notif doit partir pour une convention validée mais dont la date de fin n'est pas encore passée ?
| }); | ||
|
|
||
| it("sends emails to convention beneficiaries in affected statuses only", async () => { | ||
| const concelledConvention: ConventionDto = { |
Contributor
There was a problem hiding this comment.
Suggested change
| const concelledConvention: ConventionDto = { | |
| const cancelledConvention: ConventionDto = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist avant RfR
État de la PR
#ID_ISSUE - Message clair et en français, compréhensible par quelqu'un du métier/document-issue)Revue du code (self-review)
console.log,TODOou code de debug restant