#4999 - Listing des actions à effectué pour les bilans - Ne pas inclure les bilans créés il y a moins de 2 jours#5202
Open
Hidden character warning
The head ref may contain hidden characters: "4999-etq-prescripteur-je-ne-veux-voir-dans-les-relances-bilans-pour-signature-uniquement-les-bilans-compl\u00e9t\u00e9s-il-y-a-au-moins-2-jours"
Conversation
|
📌 Deploy a review app for this PR: ➡️ Click here to deploy review app When clicking the link above:
|
Signed-off-by: Benjamin Bohec <bbohec.pro@gmail.com>
bbohec
force-pushed
the
4999-etq-prescripteur-je-ne-veux-voir-dans-les-relances-bilans-pour-signature-uniquement-les-bilans-complétés-il-y-a-au-moins-2-jours
branch
from
9e4a740 to
e33eec7
Compare
bbohec
changed the title
tpicaud
requested changes
Jun 24, 2026
| uow = createInMemoryUow(); | ||
| timeGateway = new CustomTimeGateway(now); | ||
| const uowPerformer = new InMemoryUowPerformer(uow); | ||
| useCase = makeGetConventionsWithUnfinalizedAssessment({ |
Contributor
There was a problem hiding this comment.
Suggested change
| useCase = makeGetConventionsWithUnfinalizedAssessment({ | |
| getConventionsWithUnfinalizedAssessment = makeGetConventionsWithUnfinalizedAssessment({ |
Au vu du refacto, même si c'est long je suis partisant du nommage des useCase
| it("passes pagination produced by getPaginationParamsForWeb", async () => { | ||
| const currentUser = new ConnectedUserBuilder() | ||
| .withId(agencyUserId) | ||
| it("throws when user have not the right agency role", async () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it("throws when user have not the right agency role", async () => { | |
| it("throws when user does not have the right agency role", async () => { |
| isNotifiedByEmail: true, | ||
| }, | ||
| ]) | ||
| it("throws when user have no agency rights", async () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it("throws when user have no agency rights", async () => { | |
| it("throws when user has no agency rights", async () => { |
| currentUserWithToReviewAgencyRight, | ||
| ), | ||
| errors.agencies.noAgencyRights(currentUserWithToReviewAgencyRight.id), | ||
| ); |
Contributor
There was a problem hiding this comment.
Plusieurs tests supprimés dans ce refacto
à mon gout il faudrait à minima garder les tests sur la pagination, et aussi un test avec 2 agences = droits pour vérifier que les conventions de toutes les agences sont bien récupérées
| @@ -79,66 +78,7 @@ describe("GetConventionsForAgencyUser", () => { | |||
| uow.conventionRepository.setConventions(conventions); | |||
| }); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Pourquoi supprimer ces tests ? Le use case n'a pas été touché
| expectToEqual(result.data, []); | ||
| }); | ||
|
|
||
| it("include assessments created juste before two days ago", async () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it("include assessments created juste before two days ago", async () => { | |
| it("include assessments created just before two days ago", async () => { |
| @@ -403,25 +403,6 @@ describe("authenticatedConventionRoutes", () => { | |||
| }, | |||
| }, | |||
| }); | |||
Contributor
There was a problem hiding this comment.
idem à mes commentaires plus bas, je ne comprends pas le retrait de la pagination et des tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist avant RfR
État de la PR
#ID_ISSUE - Message clair et en français, compréhensible par quelqu'un du métier/document-issue)Revue du code (self-review)
console.log,TODOou code de debug restantPoints d'attention pour le reviewer