fix(auth): Keep login redirect in browser history#118614
Closed
scttcper wants to merge 1 commit into
Closed
Conversation
The SPA 401 handler was replacing the current history entry when sending users to login. Let it push the login route instead so back navigation can return to the page that hit auth. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 85063ab. Configure here.
|
|
||
| if (EXPERIMENTAL_SPA) { | ||
| apiNavigate?.('/auth/login/', {replace: true}); | ||
| apiNavigate?.('/auth/login/'); |
Contributor
There was a problem hiding this comment.
Parallel 401s duplicate login entries
Medium Severity
Removing {replace: true} from the SPA login redirect means every in-flight 401 runs this handler while the URL is still the protected page. Each call uses a history push to /auth/login/, so one expired session can stack many login entries and make the back button unusable in local SPA mode.
Reviewed by Cursor Bugbot for commit 85063ab. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in SPA mode (mostly local dev) do not replace history with /auth/login/ and allow users to get back to where they were