fix(project-creation): Preserve detected selection on back-to-recommended#118506
Open
jaydgoss wants to merge 1 commit into
Open
fix(project-creation): Preserve detected selection on back-to-recommended#118506jaydgoss wants to merge 1 commit into
jaydgoss wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
force-pushed
the
jaygoss/scm-back-to-recommended-fixes
branch
from
2d65871 to
b250e42
Compare
jaydgoss
force-pushed
the
jaygoss/scm-back-to-recommended-fixes
branch
from
b250e42 to
837c7ab
Compare
jaydgoss
force-pushed
the
jaygoss/scm-back-to-recommended-fixes
branch
from
837c7ab to
41e7c12
Compare
jaydgoss
force-pushed
the
jaygoss/scm-back-to-recommended-fixes
branch
from
41e7c12 to
fd29eea
Compare
jaydgoss
changed the base branch from
master
to
jaygoss/scm-styled-notification-options
jaydgoss
force-pushed
the
jaygoss/scm-styled-notification-options
branch
from
415d0ac to
f217b66
Compare
jaydgoss
force-pushed
the
jaygoss/scm-back-to-recommended-fixes
branch
from
fd29eea to
a873e3e
Compare
…nded handleBackToRecommended reset the selected features and project-details form whenever a detected platform existed, even when the platform did not change. Two problems followed: opening the manual picker and returning without a different choice wiped customized features and the project name, and returning while a non-top detected platform was selected switched it to the top detection, clearing a valid choice. Return early when the active platform is already one of the detected ones, mirroring handleSelectDetectedPlatform. Only a manual (non-detected) pick now falls back to the top detection, since the cards view cannot display it otherwise.
jaydgoss
force-pushed
the
jaygoss/scm-styled-notification-options
branch
from
f217b66 to
e55c060
Compare
jaydgoss
force-pushed
the
jaygoss/scm-back-to-recommended-fixes
branch
from
a873e3e to
364a695
Compare
evanpurkhiser
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fix
handleBackToRecommendedso returning to the recommended view no longer clears a valid platform selection or wipes the derived features and project-details form.Details
"Back to recommended platforms" leaves the manual picker and returns to the auto-detected cards view. It reset the selected features and project-details form whenever a detected platform existed, even when the platform did not change. Two problems followed:
handleBackToRecommendednow returns early when the active platform is already one of the detected ones, mirroringhandleSelectDetectedPlatform. Only a manual (non-detected) pick falls back to the top detection, since the cards view cannot display it otherwise. Specs cover the non-top detected selection and the unchanged-return path.