Skip to content

fix(logs): Handle prototype buffer keys#117003

Draft
scttcper wants to merge 1 commit into
masterfrom
scttcper/logs-buffer-map-index
Draft

fix(logs): Handle prototype buffer keys#117003
scttcper wants to merge 1 commit into
masterfrom
scttcper/logs-buffer-map-index

Conversation

@scttcper

@scttcper scttcper commented Jun 5, 2026

Copy link
Copy Markdown
Member

Follow-up from #116996 while checking for other plain-object dynamic key indexes.\n\nThis updates the streamed logs timeseries buffer to use own-property checks before reading group values. That keeps group-by values like constructor from resolving to Object.prototype.constructor before the buffer entry exists.\n\nTested with:\n\npnpm test-ci static/app/views/explore/logs/useStreamingTimeseriesResult.spec.tsx

Use own-property checks when grouping streamed log timeseries buffers so group values like constructor do not read inherited Object properties.

Co-authored-by: Codex GPT-5 <noreply@openai.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

📊 Type Coverage Diff

Metric Before After Delta
Coverage 93.64% 93.64% ±0%
Typed 132,336 132,336 ±0
Untyped 8,986 8,988 🔴 +2
🔍 2 new type safety issues introduced

Non-null assertions (!) (2 new)

File Line Detail
static/app/views/explore/logs/useStreamingTimeseriesResult.tsx 275 groupBuffers[groupValue]!
static/app/views/explore/logs/useStreamingTimeseriesResult.tsx 490 groupBuffers[groupValue]!

This is informational only and does not block the PR.

@getsantry

getsantry Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant