fix(logs): Handle prototype buffer keys#117003
Draft
scttcper wants to merge 1 commit into
Draft
Conversation
Use own-property checks when grouping streamed log timeseries buffers so group values like constructor do not read inherited Object properties. Co-authored-by: Codex GPT-5 <noreply@openai.com>
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedNon-null assertions (
This is informational only and does not block the PR. |
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #116996 while checking for other plain-object dynamic key indexes.\n\nThis updates the streamed logs timeseries buffer to use own-property checks before reading group values. That keeps group-by values like constructor from resolving to Object.prototype.constructor before the buffer entry exists.\n\nTested with:\n\n
pnpm test-ci static/app/views/explore/logs/useStreamingTimeseriesResult.spec.tsx